Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option/ValueOption.tryGetValue and reduce testing complexity #163

Merged
merged 7 commits into from Jan 6, 2022

Conversation

TheAngryByrd
Copy link
Collaborator

@TheAngryByrd TheAngryByrd commented Dec 13, 2021

Proposed Changes

Adds tryGetValue to Option/ValueOption interface as a way to interact with anything that uses the TryGetValue pattern, specifically for dictionaries.

Also reducing the complexity of the testing section but using dotnet test and using npm-run-all to handle multiple test projects with Fable.

Types of changes

What types of changes does your code introduce to MyLib.1?
Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@TheAngryByrd TheAngryByrd marked this pull request as ready for review January 6, 2022 14:41
@TheAngryByrd TheAngryByrd changed the title Try get value Option/ValueOption.tryGetValue and reduce testing complexity Jan 6, 2022
@TheAngryByrd TheAngryByrd force-pushed the tryGetValue branch 2 times, most recently from 042b697 to 5e03813 Compare January 6, 2022 16:21
@TheAngryByrd TheAngryByrd merged commit 25b8a35 into master Jan 6, 2022
TheAngryByrd added a commit that referenced this pull request Jan 6, 2022
- [Option/ValueOption.tryGetValue and reduce testing complexity](#163) Credits [@TheAngryByrd](https://github.com/TheAngryByrd)
TheAngryByrd added a commit that referenced this pull request Jan 6, 2022
- [Option/ValueOption.tryGetValue and reduce testing complexity](#163) Credits [@TheAngryByrd](https://github.com/TheAngryByrd)
@TheAngryByrd TheAngryByrd deleted the tryGetValue branch January 11, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant