Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Option.ofPair and ValueOption.ofPair #207 #208

Merged
merged 1 commit into from Jan 20, 2023
Merged

Added Option.ofPair and ValueOption.ofPair #207 #208

merged 1 commit into from Jan 20, 2023

Conversation

AlbertoDePena
Copy link
Contributor

@AlbertoDePena AlbertoDePena commented Jan 20, 2023

Proposed Changes

Just an utility method addition on ValueOption and Option modules

Closes #207

Types of changes

What types of changes does your code introduce to FsToolkit.ErrorHandling?
Put an x in the boxes that apply and remove ones that don't apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

See issue #207

Copy link
Collaborator

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TheAngryByrd TheAngryByrd merged commit a6eb4bc into demystifyfp:master Jan 20, 2023
TheAngryByrd added a commit that referenced this pull request Jan 20, 2023
- [Added Option.ofPair and ValueOption.ofPair](#208) Credits @AlbertoDePena
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Option.ofPair
2 participants