Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Task/AsyncOption defaultValue and defaultWith #238

Merged

Conversation

sheridanchris
Copy link
Contributor

@sheridanchris sheridanchris commented Nov 24, 2023

Proposed Changes

Add a few Task/AsyncOption functions that exist in the Option module.
Reference: #234 (this PR does not fulfill the Task/AsyncResult part of this issue)

Types of changes

What types of changes does your code introduce to FsToolkit.ErrorHandling?
Put an x in the boxes that apply and remove ones that don't apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

@sheridanchris sheridanchris marked this pull request as draft November 24, 2023 02:58
@sheridanchris sheridanchris marked this pull request as ready for review November 24, 2023 03:05
Copy link
Collaborator

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Mind giving these doc comments too?

@sheridanchris
Copy link
Contributor Author

Looks great. Mind giving these doc comments too?

Done!

@TheAngryByrd TheAngryByrd merged commit 6afd93b into demystifyfp:master Nov 27, 2023
25 checks passed
TheAngryByrd added a commit that referenced this pull request Nov 27, 2023
- [Add Task/AsyncOption defaultValue and defaultWith](#238) Credits @sheridanchris
@sheridanchris sheridanchris deleted the async-and-task-option-functions branch November 27, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants