Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support voption to require function #243

Conversation

Maxumka
Copy link
Contributor

@Maxumka Maxumka commented Dec 9, 2023

Proposed Changes

@TheAngryByrd Hi.

In my company we use voption and to convert to result we need to write our own functions for different projects. For convenience I would like to have them in a package at once

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

Also added bind functions to require voption

@TheAngryByrd TheAngryByrd force-pushed the add_support_voption_to_require_function branch from 7323803 to c32eda0 Compare December 9, 2023 22:27
Copy link
Collaborator

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! And all the documentation is great :)

Note: I realized we weren't running tests in CI so I had to rebase your branch after I fixed it and force push.

@TheAngryByrd TheAngryByrd force-pushed the add_support_voption_to_require_function branch from c3ec5d4 to cf3fb78 Compare December 10, 2023 19:28
@TheAngryByrd TheAngryByrd merged commit af4b826 into demystifyfp:master Dec 10, 2023
25 checks passed
TheAngryByrd added a commit that referenced this pull request Dec 10, 2023
- [Add TaskResult.foldResult](#242) Credits @Maxumka
- [Add support voption to require function](#243) Credits Credits @Maxumka
TheAngryByrd added a commit that referenced this pull request Dec 10, 2023
- [Add TaskResult.foldResult](#242) Credits @Maxumka
- [Add support voption to require function](#243) Credits Credits @Maxumka
TheAngryByrd added a commit that referenced this pull request Dec 10, 2023
- [Add TaskResult.foldResult](#242) Credits @Maxumka
- [Add support voption to require function](#243) Credits Credits @Maxumka
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants