Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add name arg to denali-navbar/icon #53

Closed
jkusa opened this issue Dec 10, 2020 · 1 comment · Fixed by #68
Closed

Add name arg to denali-navbar/icon #53

jkusa opened this issue Dec 10, 2020 · 1 comment · Fixed by #68
Assignees
@willmsn98
Labels
released on @alpha

Comments

@jkusa
Copy link
Member

jkusa commented Dec 10, 2020

In response mode, the nav bar shows a name next to a nav icon. We need to add a name arg to denali-navbar/icon.

Example:

<a class="nav-item"><i class="d-icon d-user-profile-circle"></i><span class="icon-name">Profile</span></a>

https://denali.design/docs/2.1.0/components/navbar#responsive
@jkusa jkusa mentioned this issue Feb 10, 2021
Merged
willmsn98 added a commit that referenced this issue Feb 10, 2021
@willmsn98 @jkusa
Update tests/integration/components/denali-navbar/icon-test.js
c628adb 
Resolves #53

Co-authored-by: Jon Kilroy <jkilroy@gmail.com>
@denali-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 1.0.0-alpha.17 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@willmsn98 willmsn98

Labels
released on @alpha
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(denali-navbar/icon): updated to support name denali-design/denali-ember
3 participants
@jkusa @willmsn98 @denali-bot