fix(project): queue spinner promises on watch #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davewasmer
requested changes
Mar 26, 2017
There was a problem hiding this comment.
Oof this is a bummer, but yea, I see the race condition you are describing, and this change is unfortunately necessary for this one spot since it's all event based.
I don't see a cleaner way of doing this off the top of my head. One small tweak I'd suggest though - could we maybe call it something like spinnerStart or something? Just so it's clear that it's purely there to track spinner state, not actual build/watch state.
fixes denali-js#19 - on fast rebuilds, the change event would be fired quickly enough that it would cause the spinner to succeed before it could be started completely. This ensures the succeed call happens after the start call. It also fixes the timer
acburdine
force-pushed
the
yay-race-conditions
branch
from
037b7c9
to
bb22a4f
Compare
|
Fixed 👍 |
davewasmer
approved these changes
Jun 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19
it would cause the spinner to succeed before it could be started
completely. This ensures the succeed call happens after the start call.
It also fixes the timer