get_mask should default to shape of generating image #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Working on this now |
…tore a reference to the parent dendrogram if they are attached to one.
|
@keflavich - done! |
|
Excellent. 👍. |
ChrisBeaumont
pushed a commit
that referenced
this pull request
Sep 20, 2013
get_mask should default to shape of generating image
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it is possible to have a dendrogram structure without the image it is generated from, it makes sense to have the structure know at least about the shape of the image from which it was generated. The pixel coordinates within each node don't really make sense without that information.
get_mask()should work by default.