-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: adding url-validator via github actions #179
Conversation
Also need assistance with: Test-related links
Cookbook: AWS Amplify examples
API server
Other
MiscRelated issue:
|
Test Related Links[./vault/dendron.dev.cook.md]
[./vault/pkg.dendron-plugin.qa.test.md]
[./vault/pkg.dendron-engine.qa.md]
Cookbook: AWS Amplify examples
[./vault/pkg.api-publish.arch.md]
[./vault/dendron.dev.api.seeds.md]
|
GitHub doesn't like all the calls this is doing against it, and I'm going to make a follow-up issue that could enhance the URL validator approach, in the future, with some starter commands that I'd have to experiment with at a later date. This approach would allow for internal links as well as external links, and would ensure that the site can build without errors. It seemed like using # container
# node:14-bullseye-slim
npm install broken-link-checker
npm install serve
npm install @dendronhq/dendron-cli@latest
npm install @dendronhq/dendron-11ty@latest
npx dendron-cli buildSiteV2 --wsRoot . --stage prod
npx serve 2>> /dev/null &
blc http://localhost:5000/notes -ro --exclude-internal > output-internal.log
blc http://localhost:5000/notes -ro --exclude-external > output-external.log |
URL validator addition to the repo. This includes an auditor that runs against new PRs, and also includes all the fixes I needed to add based on broken links.
Follow-up issue, based on findings, as it would make sense to make use of a different broken-link checking tool: #183