fix: issue with webpack devCLI

dendronhq · Sep 2, 2021 · a4ff4c9 · a4ff4c9
1 parent 98de787
commit a4ff4c9
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/packages/common-all/data/dendron-yml.validator.json b/packages/common-all/data/dendron-yml.validator.json
@@ -9,6 +9,10 @@
           "type": "boolean",
           "description": "Disable caching behavior"
         },
+        "maxPreviewsCached": {
+          "type": "number",
+          "description": "Maximum number of rendered previews to cache in Dendron Engine. Note: this value is ignored when  {@link  DendronConfig.noCaching }  is set to true. When set this value must be greater than 0."
+        },
         "noTelemetry": {
           "type": "boolean",
           "description": "Disable telemetry"

diff --git a/packages/dendron-cli/src/commands/devCLICommand.ts b/packages/dendron-cli/src/commands/devCLICommand.ts
@@ -5,7 +5,6 @@ import {
 } from "@dendronhq/common-all";
 import yargs from "yargs";
 import { CLICommand } from "./base";
-import * as tsj from "ts-json-schema-generator";
 import path from "path";
 import fs from "fs-extra";
 import {
@@ -98,6 +97,8 @@ export class DevCLICommand extends CLICommand<CommandOpts, CommandOutput> {
       "dendron-yml.validator.json"
     );
     const configType = "DendronConfig";
+    // NOTE: this is removed by webpack when building plugin which is why we're loading this dynamically
+    const tsj = require("ts-json-schema-generator");
     const schema = tsj
       .createGenerator({
         path: path.join(pkgRoot, "src", "config.ts"),

diff --git a/packages/dendron-next-server/data/dendron-yml.validator.json b/packages/dendron-next-server/data/dendron-yml.validator.json
@@ -9,6 +9,10 @@
           "type": "boolean",
           "description": "Disable caching behavior"
         },
+        "maxPreviewsCached": {
+          "type": "number",
+          "description": "Maximum number of rendered previews to cache in Dendron Engine. Note: this value is ignored when  {@link  DendronConfig.noCaching }  is set to true. When set this value must be greater than 0."
+        },
         "noTelemetry": {
           "type": "boolean",
           "description": "Disable telemetry"