fix: slugify github issue title (#1218)

* fix: slugify github issue title * fix: testcase fixed
dendronhq · Aug 26, 2021 · e6c2638 · e6c2638
1 parent 4d344fe
commit e6c2638
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/packages/engine-test-utils/src/__tests__/pods-core/GithubPod.spec.ts b/packages/engine-test-utils/src/__tests__/pods-core/GithubPod.spec.ts
@@ -35,7 +35,7 @@ describe("GithubPod import pod", () => {
         ],
       },
     };
-    fname = "github.issues.902-Test Issue";
+    fname = "github.issues.902-test-issue";
   });
 
   test("Import Issue with status: open", async () => {

diff --git a/packages/pods-core/src/builtin/GithubPod.ts b/packages/pods-core/src/builtin/GithubPod.ts
@@ -19,6 +19,7 @@ import {
   Time,
   DEngineClient,
   ERROR_SEVERITY,
+  getSlugger,
 } from "@dendronhq/common-all";
 
 const ID = "dendron.github";
@@ -216,15 +217,18 @@ export class GithubImportPod extends ImportPod<GithubImportPodConfig> {
     fname: string,
     config: ImportPodConfig
   ) => {
+    const slugger = getSlugger();
     return data.map((d: any) => {
       const labels = d.node.labels.edges;
       let tags: any;
       if (labels.length > 0) {
         tags = labels.map((label: any) => label.node.name);
       }
-      d.node.title = d.node.title.replace(
-        /[`~!@#$%^&*()_|+\-=?;:'",.<>\{\}\[\]\\\/]/gi, // eslint-disable-line
-        ""
+      d.node.title = slugger.slug(
+        d.node.title.replace(
+          /[`~!@#$%^&*()_|+\-=?;:'",.<>\{\}\[\]\\\/]/gi, // eslint-disable-line
+          ""
+        )
       );
       d.node = {
         body: d.node.body,