Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow LaTeX comments in math blocks #2330

Open
1 of 7 tasks
funnym0nk3y opened this issue Feb 2, 2022 · 2 comments
Open
1 of 7 tasks

Allow LaTeX comments in math blocks #2330

funnym0nk3y opened this issue Feb 2, 2022 · 2 comments
Labels
scope.views Related to Preview, TreeView, UI Panels, and other webviews sprint.backlog type.bug Something isn't working

Comments

@funnym0nk3y
Copy link

Please select the area your bug applies to. (Multiple selections are Possible. You can leave blank if you're not sure.)

  • Workspace. VSCode workspace, vaults, Intellisense/autocomplete, Dendron settings
  • Lookup. Dendron's Lookup Command
  • Views. Dendron Preview, Tree View, Side Panels in the UI
  • Schema. Dendron Schemas
  • Pod. Data import from / export to Dendron
  • Publish. External Site Publish
  • Markdown. Markdown features, such as syntax support and features

Describe the bug

When using comments in a math block, which are specific to LaTeX the math view breaks.

To Reproduce

Steps to reproduce the behavior:

  1. Create math block with $$ $$
  2. Write math
  3. Comment one line with %

Expected behavior

Math view should still be woring even with comments like the default markdown preview.

Desktop (please complete the following information)

  • OS: Win10
  • Version: 0.80
@github-actions github-actions bot added scope.views Related to Preview, TreeView, UI Panels, and other webviews status.triage-needed type.bug Something isn't working labels Feb 2, 2022
@Harshita-mindfire
Copy link
Contributor

Thanks for the issue report! I can repro this one.

@SeriousBug
Copy link
Contributor

Hi, unfortunately this is not something we'll be able to fix at this time because VSCode does not allow ESM packages, and latest versions of katex are ESM only. We are already at the latest supported version, so we have to wait until VSCode adds support for ESM.

I did find that the comments are partially supported though:

Screenshot_20220211_041646

You can see that the "foo" at the end is not displayed thanks to the comment.

@SeriousBug SeriousBug removed their assignment Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope.views Related to Preview, TreeView, UI Panels, and other webviews sprint.backlog type.bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants