Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workspace): correct title generartion for notes with sub-hierarchy starting with .md #2369

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

Harshita-mindfire
Copy link
Contributor

Basics

Extended

  • General
    • check whether code be simplified
    • check if similar function already exist in the codebase. if so, can it be re-used?
    • check if this change adversely impact performance
  • Operations
    • when shipping this change, will it just work or will it introduce additional operational overhead due to complicated interface or known bugs?
  • Architecture
    • check if code is introducing changes on a foundational class or interface. if so, call for design review if needed

@Harshita-mindfire
Copy link
Contributor Author

Related issue: #1972 and #856

madge report: now new circular dependencies(64)

@Harshita-mindfire Harshita-mindfire changed the title fix(workspace): correct title generartion of notes with sub-hierarchy… fix(workspace): correct title generartion for notes with sub-hierarchy… Feb 7, 2022
@Harshita-mindfire Harshita-mindfire changed the title fix(workspace): correct title generartion for notes with sub-hierarchy… fix(workspace): correct title generartion for notes with sub-hierarchy starting with .md Feb 7, 2022
@Harshita-mindfire Harshita-mindfire marked this pull request as ready for review February 7, 2022 16:44
@auto-assign auto-assign bot requested a review from kevinslin February 7, 2022 16:44
Copy link
Contributor

@SeriousBug SeriousBug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left one nitpick on simplifying the code.

packages/common-all/src/dnode.ts Show resolved Hide resolved
@kevinslin kevinslin merged commit 562f2bd into master Feb 9, 2022
@kevinslin kevinslin deleted the fix/title-generation-for-notes branch February 9, 2022 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants