Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: add configuration for vault selection behavior, change prompt vault selection default to true #1960

Merged
merged 4 commits into from Jan 20, 2022
Merged

enhance: add configuration for vault selection behavior, change prompt vault selection default to true #1960

merged 4 commits into from Jan 20, 2022

Conversation

nickolay-kondratyev
Copy link
Contributor

enhance: add configuration for vault selection behavior, change prompt vault selection default to true

enhance: add configuration for vault selection behavior, change prompt vault selection default to true

General

Doc PR: dendronhq/dendron-site#329

Quality Assurance

  • Add a test for the new feature
  • Make sure all the existing tests pass
  • Do a spot check by running your feature with our test workspace
  • If your tests involve running [[manual Testing|dendron://dendron.dendron-site/dendron.dev.qa.test#manual-testing]], make sure to update [[Test Workspace|dendron://dendron.dendron-site/dendron.dev.ref.test-workspace]] with any necessary notes/additions to perform manual test ^9jtWc6ov340p
  • After you submit your pull request, check the output of our integration test and make sure all tests pass
    • NOTE: If you running MacOS or Linux, pay special attention to the Windows output and vice versa if you are developing on Windows

@auto-assign auto-assign bot requested a review from kevinslin December 22, 2021 12:25
hikchoi
hikchoi suggested changes Dec 23, 2021
View reviewed changes
Copy link
Contributor

@hikchoi hikchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments.

packages/common-all/src/constants/configs/commands.ts Outdated Show resolved Hide resolved
packages/plugin-core/src/components/lookup/vaultSelectionModeKeeper.ts Outdated Show resolved Hide resolved
@hikchoi
Copy link
Contributor

hikchoi commented Jan 11, 2022

This will hopefully resolve #2042 as well

@nickolay-kondratyev nickolay-kondratyev force-pushed the enhance/vault-selection-on-note-create-v2 branch from 700efd4 to 53c2446 Compare January 14, 2022 12:37
hikchoi
hikchoi suggested changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@hikchoi hikchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick on config key naming but otherwise tried it out and works as described

packages/common-all/src/types/configs/commands/lookup.ts Outdated Show resolved Hide resolved
kevinslin
kevinslin requested changes Jan 17, 2022
View reviewed changes
Copy link
Member

@kevinslin kevinslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a comment in the naming thread in addition to this pr review

packages/plugin-core/src/components/lookup/vaultSelectionModeConfig.ts Outdated Show resolved Hide resolved
@nickolay-kondratyev nickolay-kondratyev force-pushed the enhance/vault-selection-on-note-create-v2 branch from e85e9f2 to 45a06a1 Compare January 18, 2022 16:24
@hikchoi hikchoi merged commit 38afae2 into master Jan 20, 2022
@hikchoi hikchoi deleted the enhance/vault-selection-on-note-create-v2 branch January 20, 2022 08:47
@Harshita-mindfire Harshita-mindfire mentioned this pull request Feb 7, 2022
Merged
8 tasks
@opcon opcon mentioned this pull request Feb 8, 2022
Merged
16 tasks
@jonathanyeung jonathanyeung mentioned this pull request Feb 9, 2022
Merged
28 tasks
@eleweek eleweek mentioned this pull request Feb 9, 2022
Merged
28 tasks
@SeriousBug SeriousBug mentioned this pull request Feb 9, 2022
Merged
28 tasks
@eleweek eleweek mentioned this pull request Feb 10, 2022
Merged
28 tasks
@kevinslin kevinslin mentioned this pull request Feb 10, 2022
Merged
8 tasks
@jonathanyeung jonathanyeung mentioned this pull request Feb 11, 2022
Merged
18 tasks
@Harshita-mindfire Harshita-mindfire mentioned this pull request Feb 11, 2022
Merged
20 tasks
@benhsm benhsm mentioned this pull request Feb 13, 2022
Merged
16 tasks
@hikchoi hikchoi mentioned this pull request Feb 14, 2022
Merged
7 tasks
@Harshita-mindfire Harshita-mindfire mentioned this pull request Feb 14, 2022
Merged
28 tasks
@hikchoi hikchoi mentioned this pull request Feb 15, 2022
Merged
11 tasks
@Harshita-mindfire Harshita-mindfire mentioned this pull request Sep 19, 2022
Merged
16 tasks
@hikchoi hikchoi mentioned this pull request Sep 20, 2022
Merged
13 tasks
@Harshita-mindfire Harshita-mindfire mentioned this pull request Sep 21, 2022
Closed
28 tasks
@hkievet hkievet mentioned this pull request Sep 22, 2022
Merged
28 tasks
This was referenced Sep 22, 2022
Merged
Merged
This was referenced Sep 23, 2022
Merged
Merged
@Harshita-mindfire Harshita-mindfire mentioned this pull request Sep 27, 2022
Merged
14 tasks
@hikchoi hikchoi mentioned this pull request Sep 28, 2022
Merged
17 tasks
@Harshita-mindfire Harshita-mindfire mentioned this pull request Sep 29, 2022
Merged
14 tasks
@hikchoi hikchoi mentioned this pull request Sep 30, 2022
Merged
15 tasks
This was referenced Sep 30, 2022
Merged
Merged
@hikchoi hikchoi mentioned this pull request Oct 7, 2022
Merged
13 tasks
@Harshita-mindfire Harshita-mindfire mentioned this pull request Oct 13, 2022
Merged
15 tasks
@namjul namjul mentioned this pull request Oct 14, 2022
Merged
28 tasks
@Harshita-mindfire Harshita-mindfire mentioned this pull request Oct 20, 2022
Merged
17 tasks
@hikchoi hikchoi mentioned this pull request Oct 21, 2022
Merged
10 tasks
@Harshita-mindfire Harshita-mindfire mentioned this pull request Oct 25, 2022
Merged
28 tasks
This was referenced Nov 7, 2022
Closed
Merged
@Harshita-mindfire Harshita-mindfire mentioned this pull request Nov 8, 2022
Merged
16 tasks
This was referenced Nov 9, 2022
Merged
Merged
Merged
@Harshita-mindfire Harshita-mindfire mentioned this pull request Nov 15, 2022
Merged
11 tasks
@hikchoi hikchoi mentioned this pull request Dec 2, 2022
Merged
14 tasks
@namjul namjul mentioned this pull request Dec 7, 2022
Merged
@Harshita-mindfire Harshita-mindfire mentioned this pull request Dec 7, 2022
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinslin kevinslin kevinslin approved these changes

@hikchoi hikchoi hikchoi approved these changes

Assignees

@kevinslin kevinslin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nickolay-kondratyev @hikchoi @kevinslin