Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong preview/linking when hierarchy segment starts with "md" #2644

Closed
2 of 7 tasks
gbieging opened this issue Mar 28, 2022 · 5 comments
Closed
2 of 7 tasks

Wrong preview/linking when hierarchy segment starts with "md" #2644

gbieging opened this issue Mar 28, 2022 · 5 comments
Assignees
Labels
scope.views Related to Preview, TreeView, UI Panels, and other webviews scope.workspace Workspace related functionality (i.e. intellisense, vault, workspace) status.info-needed More information is needed from filer for issue to be actionable type.bug Something isn't working

Comments

@gbieging
Copy link

Please select the area your bug applies to. (Multiple selections are Possible. You can leave blank if you're not sure.)

  • Workspace. VSCode workspace, vaults, Intellisense/autocomplete, Dendron settings
  • Lookup. Dendron's Lookup Command
  • Views. Dendron Preview, Tree View, Side Panels in the UI
  • Schema. Dendron Schemas
  • Pod. Data import from / export to Dendron
  • Publish. External Site Publish
  • Markdown. Markdown features, such as syntax support and features

Describe the bug

When creating a link to a note and one of the hierarchy segments starts with "md" the preview shows the link with only the part before that segment, clicking it also opens a note with only the fast part as the name.

To Reproduce

Steps to reproduce the behavior:

  1. Open a note
  2. Write a link with a ".md" somewhere (e.g.: [[lorem.ipsum.mdolor.sit.amet]])
  3. Open preview
  4. See error
  5. Click link
  6. Wrong note opens

Expected behavior

The full link name to appear and clicking to go to the correct note

Screenshots

image

Desktop (please complete the following information)

  • OS: Windows
  • Browser: N/A
  • Versions (all that apply to bug):
    • Dendron Extension: 0.87.0
    • VS Code version: tested with 1.63.2 and 1.65.2
    • Dendron CLI:

Additional context

Add any other context about the problem here.

Dendron Log file

Please attach the output of > Dev:Dendron: Open Logs here

@github-actions github-actions bot added scope.views Related to Preview, TreeView, UI Panels, and other webviews scope.workspace Workspace related functionality (i.e. intellisense, vault, workspace) status.triage-needed type.bug Something isn't working labels Mar 28, 2022
@SeriousBug
Copy link
Contributor

Thanks for reporting this problem, I can reproduce it. We'll fix this as soon as possible.

@aleksey-rowan
Copy link
Contributor

aleksey-rowan commented Mar 28, 2022

A very similar issue was reported last week, but it was closed as it referred to using external links inside a wiki link:

Also linking two tangentially-related issues that were fixed before (they both involve having md in filename):

@gbieging
Copy link
Author

I've found two more details that might be relevant:

  • ctrl-clicking the link in the edit pane works correctly;
  • deleting a note created by clicking the broken link gives a warning that the link needs to be updated

@Harshita-mindfire
Copy link
Contributor

This should be fixed after Dendron v0.92. Feel free to comment here if that is not the case.

@Harshita-mindfire Harshita-mindfire added status.info-needed More information is needed from filer for issue to be actionable and removed status.wip labels Jun 27, 2022
@github-actions
Copy link
Contributor

This issue has been automatically closed because there has been no response to our request for more information from the original author. We don't have enough information to take action. Please reopen if the question from the maintainer has been answered and the issue is still valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope.views Related to Preview, TreeView, UI Panels, and other webviews scope.workspace Workspace related functionality (i.e. intellisense, vault, workspace) status.info-needed More information is needed from filer for issue to be actionable type.bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants