Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookups with selection2link and where multiple lines are selected create broken wikilinks #2854

Closed
2 of 7 tasks
SeriousBug opened this issue Apr 29, 2022 · 1 comment
Closed
2 of 7 tasks
Assignees
Labels
scope.lookup Anything Lookup related scope.markdown Relating to markdown features (i.e. supporting new language syntax) type.bug Something isn't working

Comments

@SeriousBug
Copy link
Contributor

Please select the area your bug applies to. (Multiple selections are Possible. You can leave blank if you're not sure.)

  • Workspace. VSCode workspace, vaults, Intellisense/autocomplete, Dendron settings
  • Lookup. Dendron's Lookup Command
  • Views. Dendron Preview, Tree View, Side Panels in the UI
  • Schema. Dendron Schemas
  • Pod. Data import from / export to Dendron
  • Publish. External Site Publish
  • Markdown. Markdown features, such as syntax support and features

Describe the bug

If multiple lines are selected when doing a lookup with selection2link set, the created link will contain multiple lines in the alias portion of the wikilink which breaks it.

To Reproduce

Steps to reproduce the behavior:

  1. Open any note, then type:
    foo
    bar
    
  2. Select both lines
  3. Use lookup with selection2link and create the link
  4. Go back to the original note, you'll see a link like:
    [[foo
    bar|current.foo-bar]]
    

Expected behavior

Lookup should strip newlines from the link while creating it.

@SeriousBug SeriousBug self-assigned this Apr 29, 2022
@github-actions github-actions bot added scope.lookup Anything Lookup related scope.markdown Relating to markdown features (i.e. supporting new language syntax) status.triage-needed type.bug Something isn't working labels Apr 29, 2022
@SeriousBug SeriousBug changed the title Lookups with selection2link and leaveTrace: true where multiple lines are selected create broken wikilinks Lookups with selection2link and where multiple lines are selected create broken wikilinks Apr 29, 2022
@SeriousBug
Copy link
Contributor Author

This has been fixed with Dendron 0.94.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope.lookup Anything Lookup related scope.markdown Relating to markdown features (i.e. supporting new language syntax) type.bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant