Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: render favicon when assetsPrefix is set #3571

Merged
merged 1 commit into from Sep 26, 2022

Conversation

Harshita-mindfire
Copy link
Contributor

@Harshita-mindfire Harshita-mindfire commented Sep 22, 2022

This Pr aims to fix the issue with rendering favicon when assetsPrefix is set

Dendron Extended PR Checklist

  • NOTE: the links don't work. you'll need to go into the wiki and use lookup to find the note until we fix some issues in the markdown export

Code

Basics

Extended

  • General
    • check whether code be simplified
    • check if similar function already exist in the codebase. if so, can it be re-used?
    • check if this change adversely impact performance
  • Operations
    • when shipping this change, will it just work or will it introduce additional operational overhead due to complicated interface or known bugs?
  • Architecture
    • check if code is introducing changes on a foundational class or interface. if so, call for design review if needed

Instrumentation

Basics

  • [~] if you are adding analytics related changes, make sure the Telemetry docs are updated

Extended

Tests

Basics

Extended

Docs

  • [~] if your change reflects documentation changes, also submit a PR to dendron-site and mention the doc PR link in your current PR
  • [~] does this change introduce a new or better way of doing things that others need to be aware of? if so, an async should be created and a process added in Development or Packages

Close the Loop

Extended

  • [~] is this a developer BREAKING change? if another person cloning from this branch will need to adjust their dependencies or mental model of the architecture, then it is. if this is the case, make sure this is communicated according to Close Loop

@Harshita-mindfire Harshita-mindfire marked this pull request as ready for review September 22, 2022 16:56
Copy link
Member

@kevinslin kevinslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a playwright test for this? @namjul - can you write up some docs on writing playwright tests and add it to [[dendron://dendron-docs/pkg.nextjs-template.qa.test]]?

@namjul
Copy link
Contributor

namjul commented Sep 23, 2022

can we add a playwright test for this? @namjul - can you write up some docs on writing playwright tests and add it to [[dendron://dendron-docs/pkg.nextjs-template.qa.test]]?

Wip: #3580

Copy link
Member

@kevinslin kevinslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since sam is working on the test in a separate pr, feel free to merge

@Harshita-mindfire Harshita-mindfire merged commit 5a24a9e into master Sep 26, 2022
@Harshita-mindfire Harshita-mindfire deleted the fix/favicon-path-on-assetsPrefix branch September 26, 2022 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants