Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: introduce sqlite as a plugabble metadata store #3401

Merged
merged 63 commits into from Aug 22, 2022

Conversation

kevinslin
Copy link
Member

@kevinslin kevinslin commented Aug 15, 2022

enhance: introduce sqlite as a plugabble metadata store

30x speed up on basic queries (50k notes, queries complete in ~5ms vs +150ms)

To use, add the following setting in dendronrc.yml or dendron.yml

workspace:
  metadataStore: sqlite

Also make sure sqlite is available on your machine.

Future work that is needed:

  • generate clients on non-mac clients
  • support incremental updates (currently, this just initializes sqlite once when the db is empty)

@kevinslin kevinslin requested a review from tma66 August 16, 2022 03:19
@kevinslin kevinslin changed the title exp/fast lookup 2 enhance: introduce sqlite as a plugabble metadata store Aug 16, 2022
@kevinslin kevinslin marked this pull request as ready for review August 16, 2022 03:19
@auto-assign auto-assign bot requested a review from bpathakota August 16, 2022 03:19
@namjul
Copy link
Contributor

namjul commented Aug 16, 2022

Quickly toying around I get prisma client not initialized when running ➜ dendron note lookup --query "curious" --vault "wiki" --attach .

@kevinslin
Copy link
Member Author

Quickly toying around I get prisma client not initialized when running ➜ dendron note lookup --query "curious" --vault "wiki" --attach .

you'll need to run yarn buildPrismaClient inside of engine-server to generate the prisma client

@namjul
Copy link
Contributor

namjul commented Aug 17, 2022

without buildPrimsaClient i would get Error: Cannot find module '../generated-prisma-client'. With having done yarn buildPrismaClient I still get Error: prisma client not initialized

packages/api-server/package.json Outdated Show resolved Hide resolved
@@ -0,0 +1,24 @@
-- CreateTable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this path naming intentional? packages/engine-server/prisma/migrations/20220819014343_add_davult/migration.sql

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autogenerated by prisma

@kevinslin kevinslin merged commit 82896af into master Aug 22, 2022
@kevinslin kevinslin deleted the exp/fast-lookup-2 branch August 22, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants