Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing test compat issues that prevent the tests from running/succeeding on Windows:
c:\
vsC:\
. We need to always do case-insensitive string comparisons when doing file path checks.\
vs/
issues.There are still some outstanding issues:
ReferenceProvider.test.ts
- I'll follow up with @SeriousBughomedir
mock. I'll try to tackle this one later@kevinslin - is there a way to add a windows flavor to the github CI pass?