feat: clarify disabled export button when editor is dirty (#434)

deneb-viz · May 13, 2024 · 24e0a6d · 24e0a6d
1 parent 8d5cc5f
commit 24e0a6d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/features/toolbar/components/toolbar-button-standard.tsx b/src/features/toolbar/components/toolbar-button-standard.tsx
@@ -141,7 +141,7 @@ const resolveClick = (command: Command) => {
 const resolveI18nKey = (command: Command) => {
     const {
         editorPreviewDebugIsExpanded,
-        editor: { applyMode },
+        editor: { applyMode, isDirty },
         visualSettings: {
             editor: {
                 interface: {
@@ -164,7 +164,7 @@ const resolveI18nKey = (command: Command) => {
         case 'editorPaneToggle':
             return 'Tooltip_Collapse_Editor_Pane';
         case 'exportSpecification':
-            return 'Button_Export';
+            return isDirty ? 'Button_Export_Dirty' : 'Button_Export';
         case 'fieldMappings':
             return 'Button_Map_Fields';
         case 'formatJson':

diff --git a/stringResources/en-US/resources.resjson b/stringResources/en-US/resources.resjson
@@ -138,6 +138,7 @@
     "Font_Family": "Font Family",
     "Button_Help": "Open help site in a new tab [Ctrl+Alt+H]",
     "Button_Export": "Generate JSON template [Ctrl+Alt+T]",
+    "Button_Export_Dirty": "Save your changes first to ensure that your specification is eligible for export.",
     "Button_Map_Fields": "Edit specification field mapping [Ctrl+Alt+F]",
     "Button_New": "New specification [Ctrl+Alt+N]",
     "Button_Apply": "Apply changes [Ctrl+Enter]",