Merge pull request #442 from deneb-viz/bugfix/advanced-x-filter-datum

fix: prevent error if no backing datum (#434)
deneb-viz · May 15, 2024 · 2d61b6a · 2d61b6a
2 parents 5470869 + e747a60
commit 2d61b6a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/features/vega-extensibility/extensibility/expressions.ts b/src/features/vega-extensibility/extensibility/expressions.ts
@@ -123,7 +123,7 @@ const pbiCrossFilterApply = (
         const item = clone(<Item>event['item']);
         const expr = getResolvedFilterExpressionForPlaceholder(
             filterExpr,
-            item.datum
+            item?.datum
         );
         if (expr) {
             parseExpression(expr);
@@ -169,14 +169,14 @@ const getResolvedFilterExpressionForPlaceholder = (
     datum: any
 ) =>
     filterExpr?.replace(/_{(.*?)}_/g, (m, m1) => {
-        const value = datum[m1];
+        const value = datum?.[m1];
         if (typeof value === 'number' || typeof value === 'boolean') {
             return `${value}`;
         }
         if (value instanceof Date) {
             return `toDate('${value}')`;
         }
-        return `'${datum[m1]}'`;
+        return `'${datum?.[m1]}'`;
     });
 
 /**

diff --git a/src/features/vega-extensibility/view/index.ts b/src/features/vega-extensibility/view/index.ts
@@ -66,7 +66,6 @@ export const VegaViewServices: IVegaViewServices = {
      */
     setSignalByName: (name: string, value: any) => {
         if (VegaViewServices.doesSignalNameExist(name)) {
-            console.log('Setting signal', name, value);
             view?.signal(name, value);
             view?.runAsync();
         }