feat!: Refresh Python API and add error handling #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rk in python as well
…ably aren't needed anyway
…y modify the amplitudes they manage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the python API to include some much-needed methods, as well as a reorganization under the hood. Now, all PyO3 code exists only in
py-rustitude(except a little error conversion inrustitude-core). Additionally, errors are now implemented to handle every use of unwrap/expect in the core package.Nodes will be required to returnResults, which can throw errors if calculations fail.BREAKING CHANGE: Most of the standard functions which can fail will now pass on
RustitudeErrors, so expect additional unwrapping in most use cases.