Skip to content

Commit

Permalink
Fixed a bug where any content in the 'fetch' was converted to True (l…
Browse files Browse the repository at this point in the history
  • Loading branch information
huangbaichao authored and dengpeng committed Jun 16, 2024
1 parent a5d78fe commit cc44952
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion api/controllers/console/datasets/datasets_document.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
import logging
from argparse import ArgumentTypeError
from datetime import datetime, timezone

from flask import request
from flask_login import current_user
from flask_restful import Resource, fields, marshal, marshal_with, reqparse
from sqlalchemy import asc, desc
from transformers.hf_argparser import string_to_bool
from werkzeug.exceptions import Forbidden, NotFound

import services
Expand Down Expand Up @@ -141,7 +143,11 @@ def get(self, dataset_id):
limit = request.args.get('limit', default=20, type=int)
search = request.args.get('keyword', default=None, type=str)
sort = request.args.get('sort', default='-created_at', type=str)
fetch = request.args.get('fetch', default=False, type=bool)
# "yes", "true", "t", "y", "1" convert to True, while others convert to False.
try:
fetch = string_to_bool(request.args.get('fetch', default='false'))
except (ArgumentTypeError, ValueError, Exception) as e:
fetch = False
dataset = DatasetService.get_dataset(dataset_id)
if not dataset:
raise NotFound('Dataset not found.')
Expand Down

0 comments on commit cc44952

Please sign in to comment.