Prevent "Could not find UID" error (#230) #250
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After further testing, I found that the latest changes to the upstream Org-mode development branch would sometimes find IDs in the org-caldav-backup.org file instead of the correct location in org-caldav-files. This could cause problems like failing to sync changes from the remote. To avoid this, I updated the PR, so org-caldav-backup.org is not opened when backing up entries to it. Then, org-find-id won't erroneously find IDs there. Also, I found the commit in 2019 that changed how org-id-find works, and I think was the original cause of #230. It was released in Org 9.4 in late 2020, which corresponds with the timing of the bug. See the mail list link above for more discussion. |
|
Closed in favor of #252. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes,
org-caldav-filesis missing fromorg-id-files, which causes an error "Could not find UID" (#230).This PR prevents the error by updating the org-id locations before searching for any IDs.
Note, upstream org-mode has also pushed a patch that should prevent the problem:
https://list.orgmode.org/87r11un9in.fsf@localhost/T/#t
But, that fix is only on the bleeding-edge of Org, not yet on the stable release. Also, I think this PR would be useful anyways, to protect against unforeseen edge cases where the needed files are missing from the org-id database.