Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strings in Dropdown Lists not Reloading #1

Closed
krypto5863 opened this issue Dec 31, 2017 · 1 comment
Closed

Strings in Dropdown Lists not Reloading #1

krypto5863 opened this issue Dec 31, 2017 · 1 comment
Labels

Comments

@krypto5863
Copy link

Editing strings found in dropdown lists and reloading strings does not reload these strings. It does work for other strings though.

@ghorsington
Copy link
Owner

ghorsington commented Dec 31, 2017

This is a somewhat intentional payoff for better performance.

IMGUI Translation Loader does not know how the plug-ins that use IMGUI use the GUI's components: some plug-ins update all components each frame update, while others may cache and reuse some GUI components (like strings). Because of that and concerns for performance, IMGUI Translation Loader does not keep track of any GUI components it encounters, as it cannot possibly determine its life cycle automatically. As a consequence, reloading strings will not always work.

For instance, some plug-ins may cache the strings inside the dropdown menus, which will cause the issue. Since I don't know the specifics of the plgu-in you're trying to translate, I cannot really help further.

More info can be found in the source code comments.

Of course, that does not mean there isn't a possible problem. If you find a plug-in that creates a dropdown inside OnGUI without caching the list's elements, please do report about that.
Until I (or you) do find such a plug-in, this issue is closed.

Do feel free to discuss the issue of retranslating strings even though this issue is marked as closed, as currently I am out of ideas as to how to do that quickly and efficiently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants