[DRAFT] add protection from recursion #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Antonboom
suggested changes
Feb 26, 2024
| @@ -48,34 +49,29 @@ func (t *Target) ModTime() (time.Time, error) { | |||
| } | |||
|
|
|||
| type Analyzer struct { | |||
| values map[string]Value | |||
| values context.Context | |||
There was a problem hiding this comment.
imho, using ctx in such way is anti-pattern
the code became more dirty
why do not just use the custom type over map?
| var issue = a.Analyze(header("A {{ SOME-VALUE }} B")) | ||
| require.NotNil(t, issue) | ||
| require.Contains(t, issue.Message(), "recursion detected") | ||
| issue = a.Analyze(header("A {{ SOME-VALUE }} C")) |
There was a problem hiding this comment.
cosmetic: something I tried to fix in the last MR - the lack of whitespaces makes the tests difficult to understand
| require.Contains(t, issue.Message(), "recursion detected") | ||
| issue = a.Analyze(header("A {{ SOME-VALUE }} C")) | ||
| require.NotNil(t, issue) | ||
| require.Contains(t, issue.Message(), "recursion detected") |
There was a problem hiding this comment.
imho, this is strange and resource ineffective to detect recursion on analyze stage:
- strange, because this error belongs to options/constructor, not method
- ineffective, because users will see the error for every analyzed package vs single misconfig error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivaion
Closes #32