fzf package missing.

[AndreasBomholtz]

After installing navi using sudo make install, and running using navi I get this error:

/opt/navi/src/ui.sh: line 4: fzf: command not found

And after running sudo apt install fzf it worked fine.

[welcome]

Thanks for opening your first issue here!

[3duard0]

Hi @AndreasBomholtz in the installation instruction there's a comment mentioning that you have to install fzf first.

[AndreasBomholtz]

Yes you are right, I missed that. Maybe I could be a little bit more clear or the script could check if it is present and give a warning about it.

[zach-is-my-name]

Hi @AndreasBomholtz in the installation instruction there's a comment mentioning that you have to install fzf first.

Where?

[AndreasBomholtz]

@zach-is-my-name I can't remember it anymore, it was over 2 years ago 😅

[denisidoro]

I believe I removed this comment from the docs. Instead, I made navi aware of the presence/absence of fzf and it should notify the user to install fzf in runtime.

Please note that if you're using a supported package manager (eg homebrew), the formula/recipe for installing navi should install fzf under the hood, so most users shouldn't need to worry about this implementation detail.

[zach-is-my-name]

Thank

I believe I removed this comment from the docs. Instead, I made navi aware of the presence/absence of fzf and it should notify the user to install fzf in runtime.

Please note that if you're using a supported package manager (eg homebrew), the formula/recipe for installing navi should install fzf under the hood, so most users shouldn't need to worry about this implementation detail.

Actually, this wasn't my experience, hence my oblique comment...
README.md states navi uses fzf under the hood. If it's using it under the hood, to me that implies it's bundled.

I followed the instructions on the alternate instructions page, because as a linux user the Brew package manager has little relevance to me.
Following those instructions I ran cargo --unlocked install navi as instructed.
The build failed because I lacked fzf. I searched the issues here and someone else running Ubuntu said to install it with apt. I did that. But because I'm running a LTS version (20.04), I wasn't getting the latest fzf package. Wondering why I still couldn't build I consulted the issues again and another Ubuntu user recommended upgrading fzf to the latest. I built that using it's latest release and install script, re-ran cargo install --locked navi, and succeeded...
Then circled back here to try to understand why this install experience was a shambles
Hope this recounting helps you on-board more Linux users because it's a solid app