-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for oh-my-zsh plugin. #101
Conversation
Thanks for opening this pull request! |
Your changes looks good to me, if you'd like, I can merge them into my PR, or you can merge your PR after this one? I'll push the changes you requested. |
I'd rather you merge my changes into your PR so that |
I've merged all of your changes into the branch. The last thing I'd like to discuss before merging is the OMZ upgrade path: I think it would make more sense as |
Made the fix from the discussion in #103. Should be all set if you want to take a last look before merging. Cheers! |
Congrats on merging your first pull request! |
Thanks for making this project, it's really cool! I'd been looking for something like this for a while.
I noticed that your shell widget is pretty much stand-alone and I wanted to be able to use navi directly as an oh-my-zsh plugin, so I added a few things to the widget and moved it to the root of the repository so that the repo can be cloned straight into the
plugins
folder and detected when added in the plugin array.I think it should be similarly simple with
fish
, but I'm not too familiar with that shell, so I'll leave it to someone else. Thenavi.plugin.zsh
file should still be sourcable as a widget for people not using oh-my-zsh, so technically theshell/
directory could be removed andnavi widget
updated to use the new file.What's included
Future Work
$BUFFER
when hittingAlt+G
to get something similar tonavi query
navi widget zsh
to usenavi.plugin.zsh
Let me know what you think. I'm working on a few cheatsheets, and will open PRs for those as they become ready.
Cheers,
Alex