Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install script #835

Merged
merged 1 commit into from Apr 24, 2023
Merged

Conversation

alexvy86
Copy link
Contributor

@alexvy86 alexvy86 commented Apr 24, 2023

Fix function that checks for the latest released version so it doesn't match an unexpected line and results in an incorrect URL being generated. Quick-and-dirty approach.

Fixes #834 .

Output of the function code with this change is correct:

image

VS the current output:

image

@welcome
Copy link

welcome bot commented Apr 24, 2023

Thanks for opening this pull request!

@denisidoro denisidoro merged commit acec1a3 into denisidoro:master Apr 24, 2023
1 check passed
@welcome
Copy link

welcome bot commented Apr 24, 2023

Congrats on merging your first pull request!

@alexvy86 alexvy86 deleted the fix-install-script branch April 24, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install script generates incorrect URL and fails, when downloading from github
2 participants