Don't add the checkbox's name attribute to its label for boolean fields.

... which was causing HTML validation errors.
denispeplin · Feb 16, 2012 · fb8f8e1 · fb8f8e1
1 parent a7307c5
commit fb8f8e1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/lib/formtastic/inputs/boolean_input.rb b/lib/formtastic/inputs/boolean_input.rb
@@ -57,8 +57,9 @@ def label_html_options
 
         input_html_options.merge(
           prev.merge(
-            :id => nil,
-            :for => input_html_options[:id]
+            :id   => nil,
+            :name => nil,
+            :for  => input_html_options[:id]
           )
         )
       end
@@ -101,4 +102,4 @@ def checked?
 
     end
   end
-end
+end
diff --git a/spec/inputs/boolean_input_spec.rb b/spec/inputs/boolean_input_spec.rb
@@ -29,6 +29,10 @@
     output_buffer.should_not have_tag('form li label input[@type="hidden"]', :count => 1) # invalid HTML5
   end
 
+  it 'should not add a "name" attribute to the label' do
+    output_buffer.should_not have_tag('form li label[@name]')
+  end
+
   it 'should generate a checkbox input' do
     output_buffer.should have_tag('form li label input')
     output_buffer.should have_tag('form li label input#post_allow_comments')