Домашнее задание 5 #12

denisstasyev · 2019-05-21T21:03:13Z

@chexex Исправил все предыдущие замечания по стилю кода, удалил ненужный закомментированный код, исправил ошибки линтера.

chexex

Обратить внимание на то, что стрелочные функцию получают родительский this, поэтому нет необходимости делать привязывание this к этим функциям

chexex · 2019-05-22T08:44:43Z

src/components/Chat/Chat.js

@@ -23,11 +23,11 @@ class Chat extends React.Component {
    );
  }

-  onMessage(message) {
+  onMessage = message => {


Выше на 18-21 строках не нужен .bind(this), так как стрелочная функция уже захватывает this

@chexex Спасибо, теперь понятны слова Мартина про отсутствие своего this у стрелочных функций

chexex · 2019-05-22T08:45:26Z

src/components/Chat/Chat.js

    this.state.worker.then(worker => {
      worker.port.postMessage(message);
    });
-  }
+  };

  getSharedWorker() {


Почему эта функция не прошла модернизацию?

@chexex не совсем понимаю почему, но кажется реакт почему-то не понимает, что я ему функцию отправляю

chexex · 2019-05-22T08:46:23Z

src/components/Chat/ExtrasPanel/FileButton/FileButton.js

@@ -20,7 +20,7 @@ class FileButton extends React.Component {



15 строка: var на const

reader.onload = () => {...}, bind убрать

chexex · 2019-05-22T08:46:32Z

src/components/Chat/ExtrasPanel/FileButton/FileButton.js

@@ -7,7 +7,7 @@ import * as actionTypes from "store/actionTypes/actionTypes";
 import ImageFileButton from "static/Chat/MessageForm/FileButton/paperclip.svg";

 class FileButton extends React.Component {
-  onFileSelect(event) {
+  onFileSelect = event => {
    event.preventDefault();
    var files = Array.from(event.target.files);


chexex · 2019-05-22T08:49:26Z

src/components/Chat/ExtrasPanel/ReactionButton/ReactionButton.js

@@ -5,14 +5,14 @@ import styles from "./styles.module.css";
 import * as actionTypes from "store/actionTypes/actionTypes";

 class ReactionButton extends React.Component {
-  sendReaction() {
+  sendReaction = () => {


Везде, где используется sendReaction больше не нужен привязывать this (убрать .bind(this))

chexex · 2019-05-22T08:49:40Z

src/components/Chat/ExtrasPanel/ReactionButton/ReactionButton.js


-  updateText() {
+  updateText = () => {


Убрать .bind(this)

chexex · 2019-05-22T08:49:59Z

src/components/Chat/MessageForm/SendButton/SendButton.js

@@ -5,11 +5,11 @@ import styles from "./styles.module.css";
 import * as actionTypes from "store/actionTypes/actionTypes";

 class SendButton extends React.Component {
-  onSubmit(event) {
+  onSubmit = event => {


Убрать .bind(this)

chexex · 2019-05-22T08:50:39Z

src/components/Chat/MessageForm/TextMessageForm/TextMessageForm.js


-  onSubmit(event) {
+  onSubmit = event => {


Убрать .bind(this)

chexex · 2019-05-22T08:50:49Z

src/components/Chat/MessageForm/TextMessageForm/TextMessageForm.js

@@ -5,18 +5,18 @@ import styles from "./styles.module.css";
 import * as actionTypes from "store/actionTypes/actionTypes";

 class TextMessageForm extends React.Component {
-  onChange(event) {
+  onChange = event => {


Убрать .bind(this)

chexex · 2019-05-22T08:52:11Z

src/components/Chat/MessageList/MessageList.js

@@ -21,7 +21,7 @@ class MessageList extends React.Component {
    this.scrollToBottom();
  }

-  handleDragAndDrop(event) {
+  handleDragAndDrop = event => {


Убрать .bind(this)

denisstasyev · 2019-05-22T09:26:29Z

@chexex Исправил все замечания кроме getSharedWorker()

chexex

Использованы ES6 возможности языка
Убраны комменты
Убраны var

6

chexex · 2019-05-22T10:10:00Z

src/utils/index.js

@@ -11,13 +11,13 @@ export function getReadableSize(size) {
 }

 export function getTime() {


export const getTime = () => {...}

chexex · 2019-05-22T10:10:46Z

src/utils/index.js

-  var date = new Date();
-  var timeRegex = "^([0-1]?[0-9]|[2][0-3]):([0-5][0-9])(:[0-5][0-9])?";
+  let date = new Date();
+  let timeRegex = "^([0-1]?[0-9]|[2][0-3]):([0-5][0-9])(:[0-5][0-9])?";
  return date.toTimeString().match(timeRegex)[0];
 }

 export function sendToServer(text, file) {


export const sendToServer (text, file) {...}

chexex · 2019-05-22T10:11:24Z

src/components/Chat/MessageList/MessageList.js

@@ -26,11 +26,11 @@ class MessageList extends React.Component {
    let files = Array.from(event.dataTransfer.files);

    files.forEach(function(file) {


files.forEach(file => {...})

chexex · 2019-05-22T10:11:50Z

src/components/Chat/ExtrasPanel/FileButton/FileButton.js

@@ -9,14 +9,14 @@ import ImageFileButton from "static/Chat/MessageForm/FileButton/paperclip.svg";
 class FileButton extends React.Component {
  onFileSelect = event => {
    event.preventDefault();
-    var files = Array.from(event.target.files);
+    let files = Array.from(event.target.files);

    files.forEach(function(file) {


files.forEach(file => {...})

denisstasyev added 2 commits May 21, 2019 23:40

Trash deleted

0493a90

Modern JS

775a39a

denisstasyev requested a review from martinkomitsky May 21, 2019 21:03

denisstasyev assigned martinkomitsky May 21, 2019

chexex reviewed May 22, 2019

View reviewed changes

Modern js fixes

034e3ba

chexex approved these changes May 22, 2019

View reviewed changes

martinkomitsky removed their request for review May 22, 2019 10:27

martinkomitsky removed their assignment May 22, 2019

denisstasyev assigned chexex May 22, 2019

chexex merged commit ff0e0f9 into master May 22, 2019

martinkomitsky deleted the sem2-hw5 branch May 24, 2019 14:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Домашнее задание 5 #12

Домашнее задание 5 #12

denisstasyev commented May 21, 2019

chexex left a comment •

edited

Loading

chexex May 22, 2019

denisstasyev May 22, 2019

chexex May 22, 2019

denisstasyev May 22, 2019

chexex May 22, 2019

chexex May 22, 2019

chexex May 22, 2019

chexex May 22, 2019

chexex May 22, 2019

chexex May 22, 2019

chexex May 22, 2019

chexex May 22, 2019

denisstasyev commented May 22, 2019

chexex left a comment

chexex May 22, 2019

chexex May 22, 2019

chexex May 22, 2019

chexex May 22, 2019

		@@ -20,7 +20,7 @@ class FileButton extends React.Component {

		@@ -11,13 +11,13 @@ export function getReadableSize(size) {
		}

		export function getTime() {

		@@ -26,11 +26,11 @@ class MessageList extends React.Component {
		let files = Array.from(event.dataTransfer.files);

		files.forEach(function(file) {

Домашнее задание 5 #12

Домашнее задание 5 #12

Conversation

denisstasyev commented May 21, 2019

chexex left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

denisstasyev commented May 22, 2019

chexex left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chexex left a comment •

edited

Loading