Updated in-memory counter

denisyukphp · Sep 8, 2021 · 0a9fbd5 · 0a9fbd5
1 parent b112067
commit 0a9fbd5
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 7 deletions.
diff --git a/src/Strategy/InMemoryCounter.php b/src/Strategy/InMemoryCounter.php
@@ -7,15 +7,23 @@ final class InMemoryCounter implements CounterInterface
     /**
      * @var int
      */
-    private $counter;
+    private $start;
+    /**
+     * @var array<string, int>
+     */
+    private $counter = [];
 
-    public function __construct(int $counter = 0)
+    public function __construct(int $start = 0)
     {
-        $this->counter = $counter;
+        $this->start = $start;
     }
 
     public function increment(string $key = 'default'): int
     {
-        return $this->counter++;
+        if (!isset($this->counter[$key])) {
+            $this->counter[$key] = $this->start;
+        }
+
+        return $this->counter[$key]++;
     }
 }
diff --git a/tests/Strategy/InMemoryCounterTest.php b/tests/Strategy/InMemoryCounterTest.php
@@ -11,8 +11,6 @@ public function testIncrement(): void
     {
         $inMemoryCounter = new InMemoryCounter(5);
 
-        for ($i = 5; $i < 10; $i++) {
-            $this->assertSame($i, $inMemoryCounter->increment());
-        }
+        $this->assertSame(5, $inMemoryCounter->increment());
     }
 }