Closes #229 - problem with Jura font-weight 700 #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deniszholob
approved these changes
Jun 7, 2020
|
Wow... ok, lol that was simple, I wonder why chrome doesn't care, but other browsers do |
|
No problem, I believe that all browsers do "faux bolding" differently, dependent on their rendering methods, and Chrome is just better at it. I have found sometimes Chrome hides actual issues because it compensates for them so well :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the Jura font at weight
700is rendered incorrectly on some browsers, as per issue #229. This is due to the web font at this weight not being requested from Google Fonts. This PR specifies the web font weights we need from Google fonts, and fixes the issue.Screenshot before:
Screenshot after
(Screenshots are a little blurry due to being taken on browserstack in mac, but I've also tested the fix on Windows machine and looks even better 馃憤 )