support julia v0.6 #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylxdzsw
force-pushed
the
master
branch
2 times, most recently
from
8cc2b9c
to
4c9a46b
Compare
|
Looks great, thanks. Working on the warnings now... |
|
Would it make sense to use TakingBroadcastsSeriously.jl for this, or does that just complicate things? |
|
I think that is definitely an option. Let me get one version that runs on
v4, v5 and v6 without too many warnings. We can then branch and try other
solutions, which should involve minimal code change.
…On Thu, Jul 27, 2017 at 5:09 PM Mike J Innes ***@***.***> wrote:
Would it make sense to use TakingBroadcastsSeriously.jl for this, or does
that just complicate things?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#24 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABvNpm1ztz4TDy4Y00-ydQdiNZd05hugks5sSJoPgaJpZM4OjmSq>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes AutoGrad work in Julia v0.6 by
begin ... end) in gradient expressions._dbg(x::Tuple)which crashes when called with something likeRec{Tuple{Float64, Float64}}Though it raises a lot of warnings, this branch passes the tests on Julia 0.6.0.