New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support julia v0.6 #24

Merged
merged 1 commit into from Jul 29, 2017

Conversation

Projects
None yet
3 participants
@ylxdzsw
Contributor

ylxdzsw commented Jul 26, 2017

This PR makes AutoGrad work in Julia v0.6 by

  1. overload the broadcast operations deprecated in Julia v0.6 by this trick.
  2. circumvent some broadcast fusing by using blocks (begin ... end) in gradient expressions.
  3. fix a little bug in _dbg(x::Tuple) which crashes when called with something like Rec{Tuple{Float64, Float64}}

Though it raises a lot of warnings, this branch passes the tests on Julia 0.6.0.

@ylxdzsw ylxdzsw force-pushed the ylxdzsw:master branch 2 times, most recently from 8cc2b9c to 4c9a46b Jul 26, 2017

@ylxdzsw ylxdzsw force-pushed the ylxdzsw:master branch from 4c9a46b to 6467f7f Jul 26, 2017

@denizyuret

This comment has been minimized.

Owner

denizyuret commented Jul 27, 2017

Looks great, thanks. Working on the warnings now...

@MikeInnes

This comment has been minimized.

MikeInnes commented Jul 27, 2017

Would it make sense to use TakingBroadcastsSeriously.jl for this, or does that just complicate things?

@denizyuret

This comment has been minimized.

Owner

denizyuret commented Jul 27, 2017

@denizyuret denizyuret merged commit 6467f7f into denizyuret:master Jul 29, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment