Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

svd and qr functionality lost #403

Open
CarloLucibello opened this issue Nov 30, 2018 · 1 comment
Open

svd and qr functionality lost #403

CarloLucibello opened this issue Nov 30, 2018 · 1 comment
Assignees
@denizyuret
Labels
KnetArray regression

Comments

@CarloLucibello
Copy link
Collaborator

CarloLucibello commented Nov 30, 2018 •
edited
Loading

We used to support svd and qr decompositions code here
but with the julia 1.0 revamp we lost the functionality and tests are broken.

In julia 1.0 the output of svd(x) is a SVD object. The decomposition can retrieved
though iteration (as in U, S, V = svd(x)) or property access (as in U = svd(x).U).

Problem is that AutoGrad doesn't support getproperty or iterate for generic objects.
@CarloLucibello CarloLucibello changed the title svd and qr svd and qr functionality lost Nov 30, 2018
@CarloLucibello
Copy link
Collaborator Author

Cf. https://discourse.julialang.org/t/registering-jacobians-of-composite-types-in-autograd-jl/18149/2

@denizyuret denizyuret self-assigned this Jan 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@denizyuret denizyuret

Labels
KnetArray regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@denizyuret @CarloLucibello @ekinakyurek