Remove ICollection<T> as an allowed interface from AV1130 #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reasoning: the ICollection<T> interface actually allows one to modify the collection, which goes against the intention of this guideline. The reason for this exception was that versions of .NET Framework before 4.5 did not include immutable collections. Closes dennisdoomen#215
dennisdoomen
approved these changes
Aug 17, 2020
|
Waiting for @bkoelman's approval |
|
Looks good to me, thanks. |
|
Awesome. Thanks for this contribution. |
mapfel
pushed a commit
to stepahead/CSharpGuidelines
that referenced
this pull request
Mar 22, 2021
…en#216) Reasoning: the ICollection<T> interface actually allows one to modify the collection, which goes against the intention of this guideline. The reason for this exception was that versions of .NET Framework before 4.5 did not include immutable collections. Closes dennisdoomen#215
bkoelman
pushed a commit
to bkoelman/CSharpGuidelinesAnalyzer
that referenced
this pull request
Feb 2, 2022
…changeable collection interfaces and types to be returned, except from private methods.
bkoelman
pushed a commit
to bkoelman/CSharpGuidelinesAnalyzer
that referenced
this pull request
Feb 2, 2022
…changeable collection interfaces and types to be returned, except from private methods.
renamorales309
added a commit
to renamorales309/Guidelines-Analyzer-CSharp
that referenced
this pull request
Sep 23, 2022
…changeable collection interfaces and types to be returned, except from private methods.
brendasmith8
pushed a commit
to brendasmith8/Guidelines-Analyzer-CSharp
that referenced
this pull request
Oct 18, 2022
…changeable collection interfaces and types to be returned, except from private methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning: the ICollection interface actually allows one to modify
the collection, which goes against the intention of this guideline. The
reason for this exception was that versions of .NET Framework before 4.5 did not
include immutable collections.
Closes #215