Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bolt 12 support #103

Closed
Sjors opened this issue Jul 28, 2021 · 6 comments
Closed

Bolt 12 support #103

Sjors opened this issue Jul 28, 2021 · 6 comments

Comments

@Sjors
Copy link
Contributor

Sjors commented Jul 28, 2021

In order to support BOLT 12 offers - for single as well as recurring - I suggest adding one or two fields to the JSON:

  1. bolt12_single
  2. bolt12_recurring

The best practice then would be to create two offers, without an amount. Like so in c-lightning:

lightning-cli offer any "Open source development donation" "Shady Super-Coder" "open-source-single-donation"
lightning-cli offer any "Open source development monthly donation" "Shady Super-Coder" "open-source-monthly-donation" null null null 1month

The site could then display these somewhere (as plain text for now, QR when mobile wallets support it).

On the donator side IIUC they use lightning-cli createinvoicerequest [bolt12]. This method is as yet undocumented, so yolo. I assume it returns an invoice that you then pay.

There's some discussion about making this flow more automated: lightning/bolts#798 (comment)

Initially perhaps bolt12_single is a good start, since recurring payments are very tedious. But they would be really awesome once there.

@renepickhardt
Copy link
Contributor

Concept ACK

@Sjors
Copy link
Contributor Author

Sjors commented Jul 29, 2021

Fwiw, I actually received a donation this way: https://twitter.com/rusty_twit/status/1420565586552057862

@dennisreimann
Copy link
Owner

@Sjors Can you open a PR with those properties added for your profile? I can take care of displaying that info then :)

@Sjors
Copy link
Contributor Author

Sjors commented Jul 30, 2021

@dennisreimann thanks! Done in #104

@dennisreimann
Copy link
Owner

I think the UX or at least description can be improved, but let's go with this as a start …

bolt12

@Sjors
Copy link
Contributor Author

Sjors commented Jul 31, 2021

Nice! A distinction between fiat and lightning could make sense, maybe just add $ and a lightning bolt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants