Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Routes and route concerns for pagination and admin search features #668

Merged
merged 2 commits into from Oct 22, 2020
Merged

Routes and route concerns for pagination and admin search features #668

merged 2 commits into from Oct 22, 2020

Conversation

denny
Copy link
Owner

@denny denny commented Oct 22, 2020

No description provided.

@denny denny added ruby Involves Ruby code plugin DEPRECATED: split into core/features/support (was: about a plugin or the code that supports them) refactoring Rewriting existing code to improve its structure, maintainability, etc main app DEPRECATED: main_app before the core plugin refactor (was: 'core' stuff that isn't in plugins) labels Oct 22, 2020
@codecov
Copy link

codecov bot commented Oct 22, 2020

Codecov Report

Merging #668 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #668   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          276       276           
  Lines         4179      4195   +16     
=========================================
+ Hits          4179      4195   +16
Impacted Files Coverage Δ
config/routes.rb 100.00% <100.00%> (ø)
plugins/ShinyBlog/config/routes.rb 100.00% <100.00%> (ø)
plugins/ShinyForms/config/routes.rb 100.00% <100.00%> (ø)
plugins/ShinyLists/config/routes.rb 100.00% <100.00%> (ø)
plugins/ShinyNews/config/routes.rb 100.00% <100.00%> (ø)
plugins/ShinyNewsletters/config/routes.rb 100.00% <100.00%> (ø)
.../controllers/shiny_pages/admin/pages_controller.rb 100.00% <100.00%> (ø)
plugins/ShinyPages/config/routes.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc582a9...39ca1d4. Read the comment docs.

@denny
Copy link
Owner Author

denny commented Oct 22, 2020

Hakiri fail was their code exploding, rather than my code having a security issue.

@denny denny merged commit 625e85e into main Oct 22, 2020
@denny denny deleted the dev/pagination branch October 22, 2020 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
main app DEPRECATED: main_app before the core plugin refactor (was: 'core' stuff that isn't in plugins) plugin DEPRECATED: split into core/features/support (was: about a plugin or the code that supports them) refactoring Rewriting existing code to improve its structure, maintainability, etc ruby Involves Ruby code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@denny