Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send first echo request at startup delay #25

Closed
wants to merge 1 commit into from

Conversation

NOYB
Copy link

@NOYB NOYB commented Sep 17, 2017

Send the first echo request at startup after specified delay (default 0ms).
This is useful to receive initial status quicker when using longer send interval setting.
Such as processes waiting on dpinger to start. But once started, don't need such frequent status.

Send the first echo request at startup after specified delay (default 0ms).
This is useful to receive initial status quicker when using longer send interval setting.
Such as processes waiting on dpinger to start.  But once started, don't need such frequent status.
@dennypage
Copy link
Owner

This change introduces a race condition in thread startup. If the desire is to send a probe as soon as possible, there are better ways to address this. I had such an approach in an early version of the code, but removed it as being not worth the effort given that most will be using 250ms probes. If you can explain your use case it would be helpful... What parameters are you starting dpinger with? Are you using long probe times? Thanks.

@NOYB
Copy link
Author

NOYB commented Sep 27, 2017

The desire is to control when the first probe is sent, independently from the send interval.
Most people using x doesn't nullify and make useless y (PC/MAC, iPhone/Android, Ford/Chevy/Dodge), especially for software.

The use case was describe in the commit message. Quicker initial status when longer send interval is desired. So that for instance the starting of a process isn't unnecessarily delayed waiting for the longer send interval.

Yes I am using longer probe times than the default (5 seconds, it suits my needs). But a 5 second initial probe delay does not.

Could you please be so kind as to describe the race condition?

If my solution doesn't meet your requirements could you please include such an option?

Thanks.

@dennypage
Copy link
Owner

I see the use case for shortening or eliminating the initial delay. I don't see a use case for lengthening it. An early version of dpinger had code to eliminate the delay--I'll look at putting it back in. Thanks.

@dennypage
Copy link
Owner

This has been addressed. Thank you again @NOYB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants