Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added port in response and fixed response #3

Merged
merged 8 commits into from
Jun 28, 2023

Conversation

aarontravass
Copy link
Contributor

@aarontravass aarontravass commented Jun 14, 2023

Thought it would be better if port is returned for testing

@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2023

Codecov Report

Merging #3 (9594871) into master (f3e5b28) will increase coverage by 15.75%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff              @@
##           master        #3       +/-   ##
============================================
+ Coverage   84.24%   100.00%   +15.75%     
============================================
  Files           2         2               
  Lines         146       163       +17     
  Branches       16        22        +6     
============================================
+ Hits          123       163       +40     
+ Misses         23         0       -23     
Impacted Files Coverage Δ
deps.ts 100.00% <ø> (ø)
mod.ts 100.00% <100.00%> (+16.42%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@talentlessguy
Copy link
Member

there's a slight coverage decrease

@aarontravass
Copy link
Contributor Author

aarontravass commented Jun 18, 2023

@talentlessguy any idea how to test this? Testing this would result in coverage being 100%

superfetch/mod.ts

Lines 16 to 22 in 316e160

} catch (error) {
if (error instanceof Deno.errors.AddrInUse) {
const newPort = random(1024, 49151)
return getFreeListener(newPort)
}
}
throw Error

@aarontravass
Copy link
Contributor Author

nevermind, I figured it out. coverage is now 100%

@talentlessguy talentlessguy merged commit 3e1d55b into deno-libs:master Jun 28, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants