Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chrore: remove Deno.test abstractions #355

Closed
erfanium opened this issue May 1, 2022 · 3 comments
Closed

chrore: remove Deno.test abstractions #355

erfanium opened this issue May 1, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@erfanium
Copy link
Member

erfanium commented May 1, 2022

we should directly use std/testing/bdd.ts or Deno.test function in our tests (not using helper functions like testWithClient).

because new deno-vscode testing feature can't detect these tests.

@erfanium erfanium added the enhancement New feature or request label May 1, 2022
@lucsoft
Copy link
Collaborator

lucsoft commented May 1, 2022

I would prefer using std/testing/bdd.ts

This would cleanup our tests more and
Deno.Test can get noisy

@Jaysok
Copy link
Contributor

Jaysok commented May 2, 2022

bdd.ts seems nice.

Most js developers would be familiar with bdd style testing convention(using describe it and so on) which is supported in most of js testing frameworks like mocha, jest and jasmine.

And I don't know deno-vscode supports bdd style test code detection for now, but IMHO it seems almost certain that it will be supported in the future, since bdd is standard feature.

@lucsoft
Copy link
Collaborator

lucsoft commented May 2, 2022

yeah i think there are some attempts at adding support for this lense in vscode

andrinheusser added a commit to andrinheusser/mongo that referenced this issue Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants