Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SSL #15

Closed
bartlomieju opened this issue Jan 21, 2019 · 8 comments
Closed

Support SSL #15

bartlomieju opened this issue Jan 21, 2019 · 8 comments
Labels
Milestone

Comments

@bartlomieju
Copy link
Collaborator

No description provided.

@bartlomieju
Copy link
Collaborator Author

This has to wait, because Deno has no TLS support right now.

@bartlomieju
Copy link
Collaborator Author

Ref denoland/deno#1568

@bartlomieju bartlomieju added this to the future milestone Feb 5, 2019
@nonnontrivial
Copy link

@bartlomieju now that the relevant Deno issue has closed, is there another blocker for this feature?

@bartlomieju
Copy link
Collaborator Author

@nonnontrivial no, not really. As described in #82 I'm spending most of my time on Deno, so if you feel like implementing it - go ahead! Otherwise, I'll tend to it after Deno 1.0 is released

@nonnontrivial
Copy link

@bartlomieju should the API follow https://node-postgres.com/features/ssl ?

@bartlomieju
Copy link
Collaborator Author

@nonnontrivial Deno connectTLS API has completely different signature: https://deno.land/typedoc/interfaces/deno.connecttlsoptions.html
The certFile argument takes a path to pem file which then is used to load all certificates contained in that file. More info: https://docs.rs/rustls/0.16.0/rustls/struct.RootCertStore.html#method.add_pem_file
Final API shape is not that important for now, we can surely work it out during PR review

@nonnontrivial
Copy link

@bartlomieju okay, excellent. Thank you for the links. I anticipate having time this weekend to get a draft PR up.

@Soremwar
Copy link
Collaborator

Closed by #249

@Soremwar Soremwar modified the milestones: future, v1.0 Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants