Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(std): bump dependencies and prefer their lighter submodules #422

Merged
merged 11 commits into from
Feb 5, 2024
Merged

deps(std): bump dependencies and prefer their lighter submodules #422

merged 11 commits into from
Feb 5, 2024

Conversation

BastiDood
Copy link
Contributor

@BastiDood BastiDood commented Feb 25, 2023

This PR bumps the std dependencies from 0.160.0 to the latest 0.180.0 (as of writing). Breaking changes upstream (i.e., renamed exports, moved files, etc.) have been addressed accordingly.

While I was bumping the versions, I also refactored some exports such that we now prefer importing submodules instead of the more general mod.ts files (which downloads a bunch of unneeded files).

@bombillazo
Copy link
Collaborator

Hey @BastiDood, thanks for the contribution, We'll try to review this and see if we can close it.

@bombillazo
Copy link
Collaborator

Hey @BastiDood , any chance you might have to update to use the latest std (0.214.0)?

@BastiDood
Copy link
Contributor Author

Sounds great! Will definitely work on that over the weekend. I'll go rebase the branch while I'm at it. 👍

@BastiDood
Copy link
Contributor Author

Hello there @bombillazo! It turns out I had some time to spare. This PR should be ready for testing now.

@bombillazo
Copy link
Collaborator

Awesome, Ill take a look at it in the weekend

Copy link
Collaborator

@bombillazo bombillazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@bombillazo
Copy link
Collaborator

@bartlomieju wanna take a look?

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

deps.ts Show resolved Hide resolved
Copy link
Collaborator

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked @iuioiua to take a look since he's been doing a lot of work on deno_std, because of their LGTM, it also LGTM to me.

Thank you @BastiDood @bombillazo

@iuioiua iuioiua mentioned this pull request Feb 5, 2024
@bombillazo bombillazo merged commit 51e34b2 into denodrivers:main Feb 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants