Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement CLIENT UNBLOCK #195

Merged
merged 2 commits into from
Feb 26, 2021
Merged

feat: Implement CLIENT UNBLOCK #195

merged 2 commits into from
Feb 26, 2021

Conversation

craigpastro
Copy link
Contributor

Part of #174.

@craigpastro
Copy link
Contributor Author

craigpastro commented Feb 24, 2021 •
edited

Hmm, acl_test failed. It looks like the CI is now using Redis 6.2 which is affecting some of the existing tests. Happy to make a quick PR for the fixes. Let me see.

@craigpastro
Copy link
Contributor Author

Okay, created #196. If that looks good I can rebase on it after.

@uki00a uki00a self-requested a review February 25, 2021 00:29
uki00a
uki00a requested changes Feb 25, 2021
View reviewed changes
Copy link
Member

@uki00a uki00a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a minor nitpick:

tests/connection_test.ts Outdated Show resolved Hide resolved
tests/connection_test.ts Outdated Show resolved Hide resolved
uki00a
uki00a approved these changes Feb 26, 2021
View reviewed changes
Copy link
Member

@uki00a uki00a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @siyopao! 👍

@uki00a uki00a merged commit 63ecfd7 into denodrivers:master Feb 26, 2021
@uki00a uki00a mentioned this pull request Feb 26, 2021
Open
16 tasks
@craigpastro craigpastro deleted the impl-client-unblock branch February 26, 2021 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uki00a uki00a uki00a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@craigpastro @uki00a