Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement CLIENT LIST #205

Merged
merged 2 commits into from
Mar 3, 2021
Merged

feat: Implement CLIENT LIST #205

merged 2 commits into from
Mar 3, 2021

Conversation

craigpastro
Copy link
Contributor

Part of #174.

ids?: number[];
}

export type ClientPauseMode = "WRITE" | "ALL";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, moved this to keep it in alphabetical order.

Copy link
Member

@uki00a uki00a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍 Just a minor nitpick:

redis.ts Outdated Show resolved Hide resolved
Copy link
Member

@uki00a uki00a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @siyopao! 👍

@uki00a uki00a merged commit f8240ac into denodrivers:master Mar 3, 2021
@uki00a uki00a mentioned this pull request Mar 3, 2021
16 tasks
@craigpastro craigpastro deleted the impl-client-list branch March 3, 2021 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants