馃毀 Implement new server commands from Redis 6 馃毀 #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is good to see! 馃榿 |
2 tasks
keroxp
requested changes
Jun 17, 2020
uki00a
requested changes
Jun 21, 2020
uki00a
approved these changes
Jun 22, 2020
|
This is awesome work @Xirui! |
|
Released in v0.10.4 馃帀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress
Use @Terkwood's #86 as request template.
Adds support for Redis Server commands.
This change set will resolve #35 . 馃殺
Commands to implement
Docs and sanity checks
Author will run each command and verify that argument names match the canonical names exposed by Redis. Minimal command form should be included in EACH doc string. Author will check each TS return type to make sure it matches server return type (Ideally these are encoded in the test). This isn't ideal since only exports trigger deno doc, but we want to have these methods documented nonetheless.
Additional requirements