Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to TS 5.4.5 #11

Open
wants to merge 1 commit into
base: branch_v5.4.5
Choose a base branch
from
Open

Upgrade to TS 5.4.5 #11

wants to merge 1 commit into from

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented May 8, 2024

Remotes:

Actions:

  1. Closed previous "Upgrade to TS 5.4.3" PR
  2. git fetch upstream
  3. git checkout upstream/release-5.4 and ensured it was on the commit of the release.
  4. git checkout -b branch_v5.4.5
  5. git push denoland
  6. git checkout -b branch_v5.4.5_patch
  7. Cherry picked changes in origin/branch_v5.3.3_patch and squashed the commits
  8. npm install && npx hereby (to build)
    • If you get a diagnostic about globals or globalThisSymbol not existing, it's because they're called denoGlobals/nodeGlobals and denoGlobalThisSymbol/nodeGlobalThisSymbol in this fork
    • If there are new usages of globals or globalThisSymbol in checker.ts, update that code to be properly handled using either denoGlobals/nodeGlobals or denoGlobalThisSymbol/nodeGlobalThisSymbol (note: globalThisType refers to the global this type and not the global globalThis type)
  9. cp built/local/typescript.js ../deno/cli/tsc/00_typescript.js
  10. Copied the .d.ts files from built/local to ../deno/cli/tsc/dts then deleted files that didn't seem necessary (ex. typescript.internal.d.ts).
  11. Reviewed the dts files and made any modifications (reverts) necessary
  12. Search for "5.4.3" in the Deno codebase and replace with the new version
  13. Check if ScriptElementKind in the ts codebase has changed and if so, align with ScriptElementKind in cli/lsp/tsc.rs
  14. Ran cargo test check and cargo test lsp
  15. Opened this PR with base branch_v5.4.5 from denoland repo

https://github.com/denoland/deno/tree/main/cli/tsc#how-to-upgrade-typescript

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant