Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update skypack imports to npm: imports #179

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

GJZwiers
Copy link
Contributor

@GJZwiers GJZwiers commented Nov 2, 2023

I wrote a code example a long time ago that uses Skypack URLs. Because that no longer seems to be actively maintained I updated them to npm: imports, which also works.

I wrote a code example a long time ago that uses Skypack URLs. Because that no longer seems to be actively maintained I updated them to npm: imports, which also works.
@@ -453,7 +453,7 @@ that provides test spies and can be used in Deno by importing it from a CDN,
such as Skypack:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the line above still references Skypack?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kwhinnery Thanks, I have updated the line to mention NPM instead.

@kwhinnery kwhinnery merged commit b46c238 into denoland:main Nov 13, 2023
1 check passed
@GJZwiers GJZwiers deleted the update_imports branch November 13, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants