Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support hard line breaks #100

Merged
merged 1 commit into from
Jan 29, 2024
Merged

feat: support hard line breaks #100

merged 1 commit into from
Jan 29, 2024

Conversation

deer
Copy link
Contributor

@deer deer commented Jan 29, 2024

closes #98

@deer deer changed the title fix: support hard line breaks feat: support hard line breaks Jan 29, 2024
@deer
Copy link
Contributor Author

deer commented Jan 29, 2024

@crowlKats, here's a small one. I just needed to expose the option that marked already provides, make sure it defaults to false, and then write a test.

crowlKats
crowlKats reviewed Jan 29, 2024
View reviewed changes
Copy link
Member

@crowlKats crowlKats left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm didnt read the message

@crowlKats crowlKats merged commit 3ac5949 into denoland:main Jan 29, 2024
1 check passed
@deer deer deleted the line_breaks branch January 29, 2024 15:25
@silloi
Copy link

silloi commented Feb 10, 2024

Thanks for your implementation 😉 I will surely use it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crowlKats crowlKats crowlKats approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an option for hard line breaks
3 participants
@deer @silloi @crowlKats