fix: stop lowercasing viewBox #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @crowlKats, I'm actively working on converting to the unified ecosystem. I'm trying to get compatibility with the existing functionality. This is an ambitious goal, but I mainly want to learn about how rehype/remark/unified work. Once we have compatibility, we can see about changing things, perhaps with a major version bump.
But as I was working on this, I noticed that we're currently converting
viewBoxtoviewbox. This is incorrect, as per the specification. I've fixed this here, and I've added a few miscellaneous tests that don't provide a lot of value to the current system, but will help me achieve compatibility with the new one.