chore: add basic md table with dollar sign test #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hashrock, since you're so fast with reviewing these, what do you think about this one? |
|
Hmm, I'm not sure. The deps has been upgraded from Regardless, there's nothing more reliable than unit tests. If this issue still occurs, let's create another issue. Thank you for your contribution! |
|
Ugh, it failed in CI. https://github.com/denoland/deno-gfm/actions/runs/7571288796/job/20618506624#step:7:89 |
|
A soft-conflict with the previous PR. I'll open a fix soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #65
@lionel-rowe @lino-levan, what do you think about this? I took the md from the issue and wrapped it with the boilerplate from the
README.mdfile and everything is rendering correctly. Changing the spacing between the pipe and dollar sign had no effect.So this PR is to just assert that the functionality works and won't break in the future.